[all-commits] [llvm/llvm-project] 9558b6: Add an "interrupt timeout" to Process, and pipe th...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9558b602b22cb7d681757c5f56d941e39a9d9d19
      https://github.com/llvm/llvm-project/commit/9558b602b22cb7d681757c5f56d941e39a9d9d19
  Author: Jim Ingham <jingham at apple.com>
  Date:   2021-05-11 (Tue, 11 May 2021)

  Changed paths:
    M lldb/include/lldb/Target/Process.h
    M lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/TargetProperties.td
    M lldb/test/API/functionalities/gdb_remote_client/TestHaltFails.py
    M lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
    M lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
    M lldb/unittests/tools/lldb-server/tests/TestClient.cpp

  Log Message:
  -----------
  Add an "interrupt timeout" to Process, and pipe that through the
ProcessGDBRemote plugin layers.

Also fix a bug where if we tried to interrupt, but the ReadPacket
wakeup timer woke us up just after the timeout, we would break out
the switch, but then since we immediately check if the response is
empty & fail if it is, we could end up actually only giving a
small interval to the interrupt.

Differential Revision: https://reviews.llvm.org/D102085