[all-commits] [llvm/llvm-project] 4eff94: [IR][AutoUpgrade] Drop align attribute from void r...

Steven Wu via All-commits all-commits at lists.llvm.org
Tue May 11 08:24:27 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4eff9469475384a59a9da407e78aa00262edcdd0
      https://github.com/llvm/llvm-project/commit/4eff9469475384a59a9da407e78aa00262edcdd0
  Author: Steven Wu <stevenwu at apple.com>
  Date:   2021-05-11 (Tue, 11 May 2021)

  Changed paths:
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/lib/IR/AutoUpgrade.cpp
    A llvm/test/Bitcode/upgrade-void-ret-attr-11.0.ll
    A llvm/test/Bitcode/upgrade-void-ret-attr-11.0.ll.bc

  Log Message:
  -----------
  [IR][AutoUpgrade] Drop align attribute from void return types

Since D87304, `align` become an invalid attribute on none pointer types and
verifier will reject bitcode that has invalid `align` attribute.

The problem is before the change, DeadArgumentElimination can easily
turn a pointer return type into a void return type without removing
`align` attribute. Teach Autograde to remove invalid `align` attribute
from return types to maintain bitcode compatibility.

rdar://77022993

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D102201




More information about the All-commits mailing list