[all-commits] [llvm/llvm-project] 6dc2a6: Remove some unnecessary explicit defaulted copy ct...

David Blaikie via All-commits all-commits at lists.llvm.org
Mon May 10 14:31:39 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6dc2a6a8c9a0e4f8b46a0ba05430b77229789b8e
      https://github.com/llvm/llvm-project/commit/6dc2a6a8c9a0e4f8b46a0ba05430b77229789b8e
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-05-10 (Mon, 10 May 2021)

  Changed paths:
    M lldb/include/lldb/DataFormatters/DumpValueObjectOptions.h
    M lldb/include/lldb/Symbol/UnwindPlan.h
    M lldb/include/lldb/Utility/Timeout.h
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxList.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxMap.cpp

  Log Message:
  -----------
  Remove some unnecessary explicit defaulted copy ctors to cleanup -Wdeprecated-copy

These types also wanted to be/were copy assignable, and using the
implicit copy ctor is deprecated in the presence of an explicit copy
ctor.

Removing the explicit copy ctor provides the desired behavior - both
ctor and assignment operator are available implicitly.

Also while I was nearby there were some missing std::moves on shared
pointer parameters.


  Commit: 174606877df46f3e8ce0c60a4c744687d3ee3271
      https://github.com/llvm/llvm-project/commit/174606877df46f3e8ce0c60a4c744687d3ee3271
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-05-10 (Mon, 10 May 2021)

  Changed paths:
    M clang-tools-extra/clangd/unittests/Matchers.h

  Log Message:
  -----------
  Clangd Matchers.h: Fix -Wdeprecated-copy by making the defaulted copy ctor and deleted copy assignment operators explicit


Compare: https://github.com/llvm/llvm-project/compare/5577e866912e...174606877df4


More information about the All-commits mailing list