[all-commits] [llvm/llvm-project] dc7549: [GlobalISel][IRTranslator] Fix bit-test lowering d...

Amara Emerson via All-commits all-commits at lists.llvm.org
Mon May 10 11:59:51 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc75499998352ffbbe0d1da196631ddb73ad47f3
      https://github.com/llvm/llvm-project/commit/dc75499998352ffbbe0d1da196631ddb73ad47f3
  Author: Amara Emerson <amara at apple.com>
  Date:   2021-05-10 (Mon, 10 May 2021)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-switch-bittest.ll

  Log Message:
  -----------
  [GlobalISel][IRTranslator] Fix bit-test lowering dropping phi edges.

For contiguous ranges we drop the last bit-test case but in doing so we skip
adding the new MBB PHI edges to the list of replacement PHI edges, and as a
result we incorrectly omit them in the G_PHI in finishPendingPhis().

Was found when bootstrapping clang with -O3 and GlobalISel enabled on Apple Silicon.




More information about the All-commits mailing list