[all-commits] [llvm/llvm-project] 1acd9a: Revert "[LICM] Hoist loads with invariant.group me...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Sat May 8 05:45:14 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1acd9a1a29ac30044ecefb6613485d5d168f66ca
      https://github.com/llvm/llvm-project/commit/1acd9a1a29ac30044ecefb6613485d5d168f66ca
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-05-08 (Sat, 08 May 2021)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LICM.cpp
    R llvm/test/Transforms/LICM/invariant.group.ll

  Log Message:
  -----------
  Revert "[LICM] Hoist loads with invariant.group metadata"

This appears to miscompile google benchmark's GetCacheSizesFromKVFS()
when compiling with -fstrict-vtable-pointers.
Runnable reproducer: https://godbolt.org/z/f9ovKqTzb
The "f.fail()" crashes with BUS error, it is compiled into testb,
and the adress it is testing is non-sensical.

This reverts commit 4c89bcadf6cae8320a1925eb9cbeb8c8c1f5f58b.




More information about the All-commits mailing list