[all-commits] [llvm/llvm-project] d21e1b: Thread safety analysis: Eliminate parameter from i...

Aaron Puchert via All-commits all-commits at lists.llvm.org
Thu May 6 14:08:47 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d21e1b79ff7d40bca537c30da706e31e48483f21
      https://github.com/llvm/llvm-project/commit/d21e1b79ff7d40bca537c30da706e31e48483f21
  Author: Aaron Puchert <aaron.puchert at sap.com>
  Date:   2021-05-06 (Thu, 06 May 2021)

  Changed paths:
    M clang/lib/Analysis/ThreadSafety.cpp

  Log Message:
  -----------
  Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)

We were modifying precisely when intersecting the lock sets of multiple
predecessors without back edge. That's no coincidence: we can't modify
on back edges, it doesn't make sense to modify at the end of a function,
and otherwise we always want to intersect on forward edges, because we
can build a new lock set for those.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D101755




More information about the All-commits mailing list