[all-commits] [llvm/llvm-project] e51086: [llvm-objdump] Add -M {att, intel} & deprecate --x8...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e510860656bb81bd90ae3cf8bb5ef4dc8cd33c18
      https://github.com/llvm/llvm-project/commit/e510860656bb81bd90ae3cf8bb5ef4dc8cd33c18
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-05-05 (Wed, 05 May 2021)

  Changed paths:
    M llvm/docs/CommandGuide/llvm-objdump.rst
    M llvm/docs/ReleaseNotes.rst
    M llvm/test/tools/llvm-objdump/X86/elf-disassemble-symbololize-operands.yaml
    A llvm/test/tools/llvm-objdump/X86/syntax-mode.s
    M llvm/tools/llvm-objdump/llvm-objdump.cpp

  Log Message:
  -----------
  [llvm-objdump] Add -M {att,intel} & deprecate --x86-asm-syntax={att,intel}

The internal `cl::opt` option --x86-asm-syntax sets the AsmParser and AsmWriter
dialect. The option is used by llc and llvm-mc tests to set the AsmWriter dialect.

This patch adds -M {att,intel} as GNU objdump compatible aliases (PR43413).

Note: the dialect is initialized when the MCAsmInfo is constructed.
`MCInstPrinter::applyTargetSpecificCLOption` is called too late and its MCAsmInfo
reference is const, so changing the `cl::opt` in
`MCInstPrinter::applyTargetSpecificCLOption` is not an option, at least without
large amount of refactoring.

Reviewed By: hoy, jhenderson, thakis

Differential Revision: https://reviews.llvm.org/D101695