[all-commits] [llvm/llvm-project] c1c1df: [mlir] Fix region successor bug in forward dataflo...

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c1c1df6347bff3167e9aa795b508f56b8fe5fbc1
      https://github.com/llvm/llvm-project/commit/c1c1df6347bff3167e9aa795b508f56b8fe5fbc1
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-05-04 (Tue, 04 May 2021)

  Changed paths:
    M mlir/lib/Analysis/DataFlowAnalysis.cpp
    M mlir/test/Transforms/sccp-structured.mlir

  Log Message:
  -----------
  [mlir] Fix region successor bug in forward dataflow analysis

We weren't properly visiting region successors when the terminator wasn't return like, which could create incorrect results in the analysis. This revision ensures that we properly visit region successors, to avoid optimistically assuming a value is constant when it isn't.

Differential Revision: https://reviews.llvm.org/D101783