[all-commits] [llvm/llvm-project] 0c2e2f: [llvm-objdump] Improve newline consistency between...

Fangrui Song via All-commits all-commits at lists.llvm.org
Tue May 4 09:56:29 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c2e2f88fbd3f3ffa2e441e08cdd17141e7bea97
      https://github.com/llvm/llvm-project/commit/0c2e2f88fbd3f3ffa2e441e08cdd17141e7bea97
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-05-04 (Tue, 04 May 2021)

  Changed paths:
    M lld/test/MachO/arm64-32-reloc-got-load.s
    M lld/test/MachO/arm64-reloc-got-load.s
    M lld/test/MachO/arm64-reloc-tlv-load.s
    M llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-failure.s
    M llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-sgpr.s
    M llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-vgpr.s
    M llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-zeroed-gfx9.s
    M llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-zeroed-raw.s
    M llvm/test/tools/llvm-objdump/ELF/symbol-table.test
    M llvm/test/tools/llvm-objdump/ELF/verdef.test
    M llvm/test/tools/llvm-objdump/ELF/verneed.test
    M llvm/test/tools/llvm-objdump/MachO/section-headers.test
    M llvm/test/tools/llvm-objdump/X86/disassemble-section-name.s
    M llvm/test/tools/llvm-objdump/X86/elf-dynamic-symbols.test
    M llvm/test/tools/llvm-objdump/all-headers.test
    M llvm/tools/llvm-objdump/ELFDump.cpp
    M llvm/tools/llvm-objdump/llvm-objdump.cpp

  Log Message:
  -----------
  [llvm-objdump] Improve newline consistency between different pieces of information

When dumping multiple pieces of information (e.g. --all-headers),
there is sometimes no separator between two pieces.
This patch uses the "\nheader:\n" style, which generally improves
compatibility with GNU objdump.

Note: objdump -t/-T does not add a newline before "SYMBOL TABLE:" and "DYNAMIC SYMBOL TABLE:".
We add a newline to be consistent with other information.

`objdump -d` prints two empty lines before the first 'Disassembly of section'.
We print just one with this patch.

Differential Revision: https://reviews.llvm.org/D101796




More information about the All-commits mailing list