[all-commits] [llvm/llvm-project] 0e8f5e: [libcxx] [test] Skip alloc counter checks for oper...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri Apr 30 23:26:58 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e8f5e4a6864839d2292ec1ddfe48b6178c01f85
      https://github.com/llvm/llvm-project/commit/0e8f5e4a6864839d2292ec1ddfe48b6178c01f85
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-05-01 (Sat, 01 May 2021)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/move.pass.cpp
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.construct/move.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.dtor/dtor.pass.cpp
    M libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp
    M libcxx/test/support/test_macros.h

  Log Message:
  -----------
  [libcxx] [test] Skip alloc counter checks for operations within the libc++ DLL

If libc++ is built as a DLL, calls to operator new within the DLL aren't
overridden if a user provides their own operator in calling code.
Therefore, the alloc counter doesn't pick up on allocations done within
std::string, so skip that check if running on windows. (Technically,
we could keep the checks if running on windows when not built as a DLL,
but trying to keep the conditionals simple.)

Differential Revision: https://reviews.llvm.org/D100219




More information about the All-commits mailing list