[all-commits] [llvm/llvm-project] c92cdb: [libc++] [test] Recommit the unsetting of LC_COLLA...

Quuxplusone via All-commits all-commits at lists.llvm.org
Fri Apr 30 11:49:45 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c92cdb48788115e093e29143d0bdf9fca32d1f61
      https://github.com/llvm/llvm-project/commit/c92cdb48788115e093e29143d0bdf9fca32d1f61
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-04-30 (Fri, 30 Apr 2021)

  Changed paths:
    M libcxx/utils/ci/run-buildbot

  Log Message:
  -----------
  [libc++] [test] Recommit the unsetting of LC_COLLATE in the builder script.

This re-reverts one piece of 1b885573327d0f6b36f24ad23d243642f658750b,
reapplying one piece of D101437 (but not the "service"-queue piece of it).

It turns out that the behavior of `grep [^ -~]`, or even `grep [A-Z]`,
depends on locale, specifically `LC_COLLATE`. So we want to make sure
we're not in any weird locale, no matter what machine we're running on.
Yes, "en_US.UTF-8" counts as weird!
https://stackoverflow.com/questions/67320156/misbehavior-of-gnu-grep-when-grepping-for-ignores-spaces
https://stackoverflow.com/questions/6799872/how-to-make-grep-a-z-independent-of-locale




More information about the All-commits mailing list