[all-commits] [llvm/llvm-project] a3a798: [InlineCost] Remove visitUnaryInstruction()

aeubanks via All-commits all-commits at lists.llvm.org
Thu Apr 29 20:36:52 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a3a798d49dfcc30fbe26bb865ac30ccda216c4a7
      https://github.com/llvm/llvm-project/commit/a3a798d49dfcc30fbe26bb865ac30ccda216c4a7
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2021-04-29 (Thu, 29 Apr 2021)

  Changed paths:
    M llvm/lib/Analysis/InlineCost.cpp

  Log Message:
  -----------
  [InlineCost] Remove visitUnaryInstruction()

The simplifyInstruction() in visitUnaryInstruction() does not trigger
for all of check-llvm. Looking at all delegates to UnaryInstruction in
InstVisitor, the only instructions that either don't have a visitor in
CallAnalyzer, or redirect to UnaryInstruction, are VAArgInst and Alloca.
VAArgInst will never get simplified, and visitUnaryInstruction(Alloca)
would always return false anyway.

Reviewed By: mtrofin, lebedev.ri

Differential Revision: https://reviews.llvm.org/D101577




More information about the All-commits mailing list