[all-commits] [llvm/llvm-project] 1141ba: [lldb-vscode] Follow up of D99989 - store some str...

walter erquinigo via All-commits all-commits at lists.llvm.org
Thu Apr 29 18:40:37 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1141ba677e09156daec8ef31d3dcdae7f59f60c5
      https://github.com/llvm/llvm-project/commit/1141ba677e09156daec8ef31d3dcdae7f59f60c5
  Author: Walter Erquinigo <wallace at fb.com>
  Date:   2021-04-29 (Thu, 29 Apr 2021)

  Changed paths:
    M lldb/tools/lldb-vscode/JSONUtils.cpp
    M lldb/tools/lldb-vscode/JSONUtils.h
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  [lldb-vscode] Follow up of D99989 - store some strings more safely

As a follow up of https://reviews.llvm.org/D99989#inline-953343, I'm now
storing std::string instead of char *. I know it might never break as char *,
but if it does, chasing that bug might be dauting.
Besides, I'm also checking of the strings gotten through the SB API are
null or not.




More information about the All-commits mailing list