[all-commits] [llvm/llvm-project] f31e39: [lldb][AArch64] Don't check for VmFlags in smaps f...

David Spickett via All-commits all-commits at lists.llvm.org
Thu Apr 29 01:30:37 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f31e390453d255bc6a486bbd5cb990e684b29510
      https://github.com/llvm/llvm-project/commit/f31e390453d255bc6a486bbd5cb990e684b29510
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2021-04-29 (Thu, 29 Apr 2021)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lldbtest.py
    M lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py

  Log Message:
  -----------
  [lldb][AArch64] Don't check for VmFlags in smaps files

AArch64 kernel builds default to having /smaps and
the "VmFlags" line was added in 3.8. Long before MTE
was supported.

So we can assume that if you're AArch64 with MTE,
you can run this test.

The previous method of checking had a race condition
where the process we read smaps for, could finish before
we get to read the file.

I explored some alternatives but in the end I think
it's fine to just assume we have what we need.

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D100493




More information about the All-commits mailing list