[all-commits] [llvm/llvm-project] 191570: Improve error messages for attributes in the wrong...

[nlewycky via All-commits]

  Branch: refs/heads/cleaner-attribute-errors
  Home:   https://github.com/llvm/llvm-project
  Commit: 191570989ba291c639034906eeb6a0bae9ed47e9
      https://github.com/llvm/llvm-project/commit/191570989ba291c639034906eeb6a0bae9ed47e9
  Author: Nick Lewycky <nicholas at mxc.ca>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M llvm/lib/IR/Attributes.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/unittests/IR/AttributesTest.cpp

  Log Message:
  -----------
  Improve error messages for attributes in the wrong context.

verifyFunctionAttrs has a comment that the value V is printed in error messages. The recently added errors for attributes didn't print V. Make them print V.

Change the stringification of AttributeList. Firstly they started with 'PAL[' which stood for ParamAttrsList. Change that to 'AttributeList[' matching its current name AttributeList. Print out semantic meaning of the index instead of the raw index value (i.e. 'return', 'function' or 'arg(n)').