[all-commits] [llvm/llvm-project] b8baa2: [ARM][AArch64] Require appropriate features for cr...

dcandler via All-commits all-commits at lists.llvm.org
Wed Apr 28 08:28:02 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b8baa2a9132498ea286dbb0d03f005760ecc6fdb
      https://github.com/llvm/llvm-project/commit/b8baa2a9132498ea286dbb0d03f005760ecc6fdb
  Author: David Candler <david.candler at arm.com>
  Date:   2021-04-28 (Wed, 28 Apr 2021)

  Changed paths:
    M clang/include/clang/Basic/arm_neon.td
    M clang/lib/Basic/Targets/AArch64.cpp
    M clang/lib/Basic/Targets/AArch64.h
    M clang/lib/Basic/Targets/ARM.cpp
    M clang/lib/Basic/Targets/ARM.h
    M clang/lib/Driver/ToolChains/Arch/ARM.cpp
    M clang/test/CodeGen/aarch64-neon-range-checks.c
    M clang/test/CodeGen/aarch64-neon-sha3.c
    M clang/test/CodeGen/aarch64-neon-sm4-sm3.c
    M clang/test/CodeGen/arm-target-features.c
    M clang/test/CodeGen/arm64_crypto.c
    M clang/test/CodeGen/neon-crypto.c
    M clang/test/Driver/aarch64-cpus.c
    M clang/test/Driver/arm-cortex-cpus.c
    M clang/test/Driver/arm-features.c
    M clang/test/Driver/arm-mfpu.c
    M clang/test/Driver/armv8.1m.main.c
    M clang/test/Preprocessor/aarch64-target-features.c
    M clang/test/Preprocessor/arm-target-features.c
    M llvm/include/llvm/Support/ARMTargetParser.def
    M llvm/lib/Support/ARMTargetParser.cpp
    M llvm/lib/Target/ARM/ARMInstrNEON.td
    M llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
    M llvm/test/Bindings/llvm-c/ARM/disassemble.test
    A llvm/test/MC/ARM/directive-arch_extension-aes-sha2.s
    M llvm/test/MC/ARM/directive-arch_extension-crypto.s
    M llvm/test/MC/ARM/neon-crypto.s

  Log Message:
  -----------
  [ARM][AArch64] Require appropriate features for crypto algorithms

This patch changes the AArch32 crypto instructions (sha2 and aes) to
require the specific sha2 or aes features. These features have
already been implemented and can be controlled through the command
line, but do not have the expected result (i.e. `+noaes` will not
disable aes instructions). The crypto feature retains its existing
meaning of both sha2 and aes.

Several small changes are included due to the knock-on effect this has:

- The AArch32 driver has been modified to ensure sha2/aes is correctly
  set based on arch/cpu/fpu selection and feature ordering.
- Crypto extensions are permitted for AArch32 v8-R profile, but not
  enabled by default.
- ACLE feature macros have been updated with the fine grained crypto
  algorithms. These are also used by AArch64.
- Various tests updated due to the change in feature lists and macros.

Reviewed By: lenary

Differential Revision: https://reviews.llvm.org/D99079




More information about the All-commits mailing list