[all-commits] [llvm/llvm-project] e01c66: Revert D76519 "[NFC] Refactor how CFI section type...

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon Apr 26 15:17:46 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e01c666b136e3f97587b22a2029f31e5c36a0e71
      https://github.com/llvm/llvm-project/commit/e01c666b136e3f97587b22a2029f31e5c36a0e71
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-04-26 (Mon, 26 Apr 2021)

  Changed paths:
    M llvm/include/llvm/CodeGen/AsmPrinter.h
    M llvm/lib/CodeGen/AsmPrinter/ARMException.cpp
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfCFIException.cpp
    M llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp

  Log Message:
  -----------
  Revert D76519 "[NFC] Refactor how CFI section types are represented in AsmPrinter"

This reverts commit 0ce723cb228bc1d1a0f5718f3862fb836145a333.

D76519 was not quite NFC. If we see a CFISection::Debug function before a
CFISection::EH one (-fexceptions -fno-asynchronous-unwind-tables), we may
incorrectly pick CFISection::Debug and emit a `.cfi_sections .debug_frame`.
We should use .eh_frame instead.

This scenario is untested.




More information about the All-commits mailing list