[all-commits] [llvm/llvm-project] 35e95c: [CVP] processCallSite returns wrong status

[ebrevnov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 35e95c68176d599780c3907afe6c0c4c5162672f
      https://github.com/llvm/llvm-project/commit/35e95c68176d599780c3907afe6c0c4c5162672f
  Author: Evgeniy Brevnov <ybrevnov at azul.com>
  Date:   2021-04-19 (Mon, 19 Apr 2021)

  Changed paths:
    M llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp

  Log Message:
  -----------
  [CVP] processCallSite returns wrong status

Recently processMinMaxIntrinsic has been added and we started to observe a number of analysis get invalidated after CVP. The problem is CVP conservatively returns 'true'  even if there were no modifications to IR. I found one more place besides processMinMaxIntrinsic  which has the same problem. I think processMinMaxIntrinsic and similar should better have boolean return status to prevent similar issue reappear in future.

Reviewed By: lebedev.ri

Differential Revision: https://reviews.llvm.org/D100538