[all-commits] [llvm/llvm-project] e880c1: [libc++] [CI] Fail if the headers contain cyclic d...
Quuxplusone via All-commits
all-commits at lists.llvm.org
Sun Apr 18 10:01:32 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: e880c19c6af3078d42e74543bb4690cbefbff4dd
https://github.com/llvm/llvm-project/commit/e880c19c6af3078d42e74543bb4690cbefbff4dd
Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
Date: 2021-04-18 (Sun, 18 Apr 2021)
Changed paths:
M libcxx/utils/ci/run-buildbot
M libcxx/utils/graph_header_deps.py
Log Message:
-----------
[libc++] [CI] Fail if the headers contain cyclic dependencies.
Since we have a tool to detect cycles now; and since we're entering
a phase where people can easily introduce cycles by accident (D100682)
or by request (D90999), I think it's increasingly important to shift
the burden of detecting these cycles onto the buildbot instead of
the poor human reviewer.
Also, grep for non-ASCII characters (such as U+200B and U+00AD)
and hard tabs; don't let those get checked in.
Differential Review: https://reviews.llvm.org/D100703
More information about the All-commits
mailing list