[all-commits] [llvm/llvm-project] be0ffb: [TableGen] Run GenerateVariants before ExpandHwMod...

Craig Topper via All-commits all-commits at lists.llvm.org
Fri Apr 16 15:08:53 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: be0ffbb21f6631a73679d371da5315db3eb3537c
      https://github.com/llvm/llvm-project/commit/be0ffbb21f6631a73679d371da5315db3eb3537c
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-04-16 (Fri, 16 Apr 2021)

  Changed paths:
    M llvm/utils/TableGen/CodeGenDAGPatterns.cpp

  Log Message:
  -----------
  [TableGen] Run GenerateVariants before ExpandHwModeBasedTypes.

A large portion of the patterns are duplicated for HwMode on RISCV.
If we expand HwMode first, we need to check nearly twice as many
patterns for variants. HwModes shouldn't affect whether a variant
is valid so we should be able to expand after.

This also reduces the RISCV isel table by 539 bytes due to factoring
working better on this pattern order. Unfortunately it increases
Hexagon table size by ~50 bytes. But I think this is a reasonable
trade.




More information about the All-commits mailing list