[all-commits] [llvm/llvm-project] d5c5cf: [AArch64] [COFF] Properly produce cross-section re...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d5c5cf5ce8d921fc8c5e1b608c298a1ffa688d37
      https://github.com/llvm/llvm-project/commit/d5c5cf5ce8d921fc8c5e1b608c298a1ffa688d37
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-04-14 (Wed, 14 Apr 2021)

  Changed paths:
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFObjectWriter.cpp
    M llvm/test/MC/AArch64/coff-relocations-diags.s
    M llvm/test/MC/AArch64/coff-relocations.s

  Log Message:
  -----------
  [AArch64] [COFF] Properly produce cross-section relative relocations

This fixes breakage on Windows/ARM64 after D94355.

Modelled after the corresponding code for X86; not entirely familiar
with those aspects of that layer otherwise.

Differential Revision: https://reviews.llvm.org/D99572


  Commit: 3b32dc4b84c8eaa0de337d6847c2c4cdbfcb4333
      https://github.com/llvm/llvm-project/commit/3b32dc4b84c8eaa0de337d6847c2c4cdbfcb4333
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-04-14 (Wed, 14 Apr 2021)

  Changed paths:
    M llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
    M llvm/test/MC/ARM/coff-relocations.s

  Log Message:
  -----------
  [ARM] [COFF] Properly produce cross-section relative relocations

Differential Revision: https://reviews.llvm.org/D99574


  Commit: 37935405efbebc4bd9f1ffac9152571c6a8469dc
      https://github.com/llvm/llvm-project/commit/37935405efbebc4bd9f1ffac9152571c6a8469dc
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-04-14 (Wed, 14 Apr 2021)

  Changed paths:
    M llvm/test/Other/lit-quoting.txt
    M llvm/utils/lit/lit/TestRunner.py

  Log Message:
  -----------
  [lit] Always quote arguments containing '[' on windows

This avoids breaking clang-tidy/infrastructure/validate-check-names.cpp
if 'not' is evaluated as a lit internal tool (making TestRunner
invoke 'grep' directly in that test, instead of invoking 'not', which
then invokes 'grep').

The quoting of arguments is still brittle if the executable is an
MSYS based tool though, as MSYS based tools incorrectly unescape
backslashes in quoted arguments (contrary to regular win32 argument
parsing rules), see D99406 and
https://github.com/msys2/msys2-runtime/issues/36 for more examples
of the issues.

Differential Revision: https://reviews.llvm.org/D99938


Compare: https://github.com/llvm/llvm-project/compare/127322ddebde...37935405efbe