[all-commits] [llvm/llvm-project] 872b1d: [lldb/test] s/add_no_ack_remote_stream/do_handshake

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 872b1da6ad276515ccfb1481009d23b129c72cac
      https://github.com/llvm/llvm-project/commit/872b1da6ad276515ccfb1481009d23b129c72cac
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
    M lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py
    M lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py
    M lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
    M lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
    M lldb/test/API/tools/lldb-server/TestGdbRemoteCompletion.py
    M lldb/test/API/tools/lldb-server/TestGdbRemoteHostInfo.py
    M lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
    M lldb/test/API/tools/lldb-server/commandline/TestGdbRemoteConnection.py

  Log Message:
  -----------
  [lldb/test] s/add_no_ack_remote_stream/do_handshake

These two functions are doing the same thing, only one of them is
sending the packets immediately and the other "queues" them to be sent
later. The first one is better as in case of errors, the backtrace will
point straight to the place that caused them.

Modify the first method to avoid duplication, and ten standardize on it.