[all-commits] [llvm/llvm-project] 5ad15f: Require commas between double square bracket attri...

[Aaron Ballman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ad15f4d1c6f56d25904265023d123a7d0b9d59d
      https://github.com/llvm/llvm-project/commit/5ad15f4d1c6f56d25904265023d123a7d0b9d59d
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
    M clang/lib/Parse/ParseDeclCXX.cpp
    M clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.nodiscard/p1.cpp
    M clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.unused/p1.cpp
    M clang/test/Parser/c2x-attributes.c
    M clang/test/Parser/cxx-attributes.cpp
    M clang/test/Parser/pragma-attribute.cpp
    M clang/test/Sema/c2x-maybe_unused-errors.c
    M clang/test/Sema/c2x-nodiscard.c

  Log Message:
  -----------
  Require commas between double square bracket attributes.

Clang currently has a bug where it allows you to write [[foo bar]] and
both attributes are silently accepted. This patch corrects the comma
parsing rules for such attributes and handles the test case fallout, as
a few tests were accidentally doing this.