[all-commits] [llvm/llvm-project] 8508a6: [mlir] Rename AVX512 dialect to X86Vector

Emilio Cota via All-commits all-commits at lists.llvm.org
Mon Apr 12 10:20:24 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8508a63b887e29d1c699f1a9cdf8b2a6164a6f0a
      https://github.com/llvm/llvm-project/commit/8508a63b887e29d1c699f1a9cdf8b2a6164a6f0a
  Author: Emilio Cota <ecg at google.com>
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
    M mlir/include/mlir/Conversion/Passes.td
    M mlir/include/mlir/Conversion/VectorToLLVM/ConvertVectorToLLVM.h
    R mlir/include/mlir/Dialect/AVX512/AVX512.td
    R mlir/include/mlir/Dialect/AVX512/AVX512Dialect.h
    R mlir/include/mlir/Dialect/AVX512/CMakeLists.txt
    R mlir/include/mlir/Dialect/AVX512/Transforms.h
    M mlir/include/mlir/Dialect/CMakeLists.txt
    A mlir/include/mlir/Dialect/X86Vector/CMakeLists.txt
    A mlir/include/mlir/Dialect/X86Vector/Transforms.h
    A mlir/include/mlir/Dialect/X86Vector/X86Vector.td
    A mlir/include/mlir/Dialect/X86Vector/X86VectorDialect.h
    M mlir/include/mlir/InitAllDialects.h
    R mlir/include/mlir/Target/LLVMIR/Dialect/AVX512/AVX512ToLLVMIRTranslation.h
    M mlir/include/mlir/Target/LLVMIR/Dialect/All.h
    A mlir/include/mlir/Target/LLVMIR/Dialect/X86Vector/X86VectorToLLVMIRTranslation.h
    M mlir/lib/Conversion/VectorToLLVM/CMakeLists.txt
    M mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVMPass.cpp
    R mlir/lib/Dialect/AVX512/CMakeLists.txt
    R mlir/lib/Dialect/AVX512/IR/AVX512Dialect.cpp
    R mlir/lib/Dialect/AVX512/IR/CMakeLists.txt
    R mlir/lib/Dialect/AVX512/Transforms/CMakeLists.txt
    R mlir/lib/Dialect/AVX512/Transforms/LegalizeForLLVMExport.cpp
    M mlir/lib/Dialect/CMakeLists.txt
    A mlir/lib/Dialect/X86Vector/CMakeLists.txt
    A mlir/lib/Dialect/X86Vector/IR/CMakeLists.txt
    A mlir/lib/Dialect/X86Vector/IR/X86VectorDialect.cpp
    A mlir/lib/Dialect/X86Vector/Transforms/CMakeLists.txt
    A mlir/lib/Dialect/X86Vector/Transforms/LegalizeForLLVMExport.cpp
    M mlir/lib/Target/LLVMIR/CMakeLists.txt
    R mlir/lib/Target/LLVMIR/Dialect/AVX512/AVX512ToLLVMIRTranslation.cpp
    R mlir/lib/Target/LLVMIR/Dialect/AVX512/CMakeLists.txt
    M mlir/lib/Target/LLVMIR/Dialect/CMakeLists.txt
    A mlir/lib/Target/LLVMIR/Dialect/X86Vector/CMakeLists.txt
    A mlir/lib/Target/LLVMIR/Dialect/X86Vector/X86VectorToLLVMIRTranslation.cpp
    M mlir/test/CMakeLists.txt
    R mlir/test/Dialect/AVX512/legalize-for-llvm.mlir
    R mlir/test/Dialect/AVX512/roundtrip.mlir
    A mlir/test/Dialect/X86Vector/legalize-for-llvm.mlir
    A mlir/test/Dialect/X86Vector/roundtrip.mlir
    R mlir/test/Integration/Dialect/Vector/CPU/AVX512/lit.local.cfg
    R mlir/test/Integration/Dialect/Vector/CPU/AVX512/test-mask-compress.mlir
    R mlir/test/Integration/Dialect/Vector/CPU/AVX512/test-sparse-dot-product.mlir
    R mlir/test/Integration/Dialect/Vector/CPU/AVX512/test-vp2intersect-i32.mlir
    A mlir/test/Integration/Dialect/Vector/CPU/X86Vector/lit.local.cfg
    A mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-mask-compress.mlir
    A mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-sparse-dot-product.mlir
    A mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-vp2intersect-i32.mlir
    R mlir/test/Target/LLVMIR/avx512.mlir
    A mlir/test/Target/LLVMIR/x86vector.mlir
    M mlir/test/lit.site.cfg.py.in
    M mlir/test/mlir-opt/commandline.mlir

  Log Message:
  -----------
  [mlir] Rename AVX512 dialect to X86Vector

We will soon be adding non-AVX512 operations to MLIR, such as AVX's rsqrt. In https://reviews.llvm.org/D99818 several possibilities were discussed, namely to (1) add non-AVX512 ops to the AVX512 dialect, (2) add more dialects (e.g. AVX dialect for AVX rsqrt), and (3) expand the scope of the AVX512 to include these SIMD x86 ops, thereby renaming the dialect to something more accurate such as X86Vector.

Consensus was reached on option (3), which this patch implements.

Reviewed By: aartbik, ftynse, nicolasvasilache

Differential Revision: https://reviews.llvm.org/D100119




More information about the All-commits mailing list