[all-commits] [llvm/llvm-project] 6dc432: Support: Use std::unique_ptr for SignpostEmitter::...

Duncan P. N. Exon Smith via All-commits all-commits at lists.llvm.org
Thu Apr 8 17:09:30 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6dc432510f29bc7e4cf7b0dfbffdd19443295cc8
      https://github.com/llvm/llvm-project/commit/6dc432510f29bc7e4cf7b0dfbffdd19443295cc8
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2021-04-08 (Thu, 08 Apr 2021)

  Changed paths:
    M llvm/include/llvm/Support/Signposts.h
    M llvm/lib/Support/Signposts.cpp

  Log Message:
  -----------
  Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC, 3rd attempt

This reverts commit e35afbe535f96086141f57a5ce7d679429b4405f, reapplying
022ccedde8877e877b45e49641544b5e4fff0b42 and
e7ed5c920db3f537a85d962c1c918a1bb6de99fd.

- The first attempt missed defining `SignpostEmitterImpl`.
- The second attempt missed defining `llvm::SignpostEmitterImpl`.

Not sure how I failed to test both versions locally before; I thought
I'd turned the feature off via rerunning `cmake` but it must have been
stuck in place. This time I confirmed via `clang -E` that I was testing
both build configurations.

Original commit message:

    Replace some manual memory management with std::unique_ptr.

    Differential Revision: https://reviews.llvm.org/D100151




More information about the All-commits mailing list