[all-commits] [llvm/llvm-project] e7ed5c: Revert "Revert "Support: Use std::unique_ptr for S...

[Duncan P. N. Exon Smith via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e7ed5c920db3f537a85d962c1c918a1bb6de99fd
      https://github.com/llvm/llvm-project/commit/e7ed5c920db3f537a85d962c1c918a1bb6de99fd
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2021-04-08 (Thu, 08 Apr 2021)

  Changed paths:
    M llvm/include/llvm/Support/Signposts.h
    M llvm/lib/Support/Signposts.cpp

  Log Message:
  -----------
  Revert "Revert "Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC""

This reverts commit 078072285d3fbdaa94f9a91140eb5c1223b548af, reapplying
022ccedde8877e877b45e49641544b5e4fff0b42.

I figured out why this was failing in other environments: it's not a
problem with std::unique_ptr, but that SignpostEmitterImpl only has a
forward declaration. Adding an empty definition should do the trick.

Original commit message:

    Replace some manual memory management with std::unique_ptr.

    Differential Revision: https://reviews.llvm.org/D100151