[all-commits] [llvm/llvm-project] e10493: [DebugInfo] Correctly track SDNode dependencies fo...

Stephen Tozer via All-commits all-commits at lists.llvm.org
Thu Apr 8 09:07:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e10493eb5012a2c313471489646bde9595ea06c0
      https://github.com/llvm/llvm-project/commit/e10493eb5012a2c313471489646bde9595ea06c0
  Author: Stephen Tozer <Stephen.Tozer at Sony.com>
  Date:   2021-04-08 (Thu, 08 Apr 2021)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    A llvm/test/CodeGen/X86/dbg-list-dependencies.ll

  Log Message:
  -----------
  [DebugInfo] Correctly track SDNode dependencies for list debug values

During SelectionDAG, we must track the SDNodes that each SDDbgValue depends on
to compute its value. These are ultimately derived from the location operands to
the SDDbgValue, but were stored in a separate vector prior to this patch. This
resulted in cases where one of the lists was updated incorrectly, resulting in
crashes during compilation. This patch fixes the issue by directly recomputing
the dependency list from the SDDbgOperands in getDependencies().

Differential Revision: https://reviews.llvm.org/D99423




More information about the All-commits mailing list