[all-commits] [llvm/llvm-project] d855a7: [lld-macho][nfc] Add test for ARM64 stubs

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d855a727bbf3dd0a8c7502980a667641b50e54d3
      https://github.com/llvm/llvm-project/commit/d855a727bbf3dd0a8c7502980a667641b50e54d3
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
    A lld/test/MachO/arm64-stubs.s

  Log Message:
  -----------
  [lld-macho][nfc] Add test for ARM64 stubs

Reviewed By: #lld-macho, gkm

Differential Revision: https://reviews.llvm.org/D99813


  Commit: 982e3c05108b606701d99d43098331357d9dd0ca
      https://github.com/llvm/llvm-project/commit/982e3c05108b606701d99d43098331357d9dd0ca
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
    M lld/MachO/SyntheticSections.h
    M lld/test/CMakeLists.txt
    M lld/test/MachO/stabs.s

  Log Message:
  -----------
  [lld-macho] Sibling N_SO symbols must have the empty string

We had been giving them a string index of zero, which actually corresponds to a
string with a single space due to {D89639}.

This was far from obvious in the old test because llvm-nm doesn't quote the
symbol names, making the empty string look identical to a string of a single
space. `dsymutil -s` quotes its strings, so I've changed the test accordingly.

Fixes llvm.org/PR48714. Thanks @clayborg for the tips!

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D100003


Compare: https://github.com/llvm/llvm-project/compare/6d5132b426fb...982e3c05108b