[all-commits] [llvm/llvm-project] 03f7b1: [X86] Initialize TargetOptions::StackProtectorGuar...

LemonBoy via All-commits all-commits at lists.llvm.org
Wed Apr 7 00:04:46 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 03f7b13d4452e3ee7749ed0cd354071eced25502
      https://github.com/llvm/llvm-project/commit/03f7b13d4452e3ee7749ed0cd354071eced25502
  Author: LemonBoy <thatlemon at gmail.com>
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
    M llvm/include/llvm/Target/TargetOptions.h

  Log Message:
  -----------
  [X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default value

D88631 introduced a set of knobs to tweak how the stack protector is codegen'd for x86 targets, including the offset from the base register where the stack cookie is located. The `StackProtectorGuardOffset` field in `TargetOptions` was left uninitialized instead of being reset to its neutral value -1, making it possible to emit nonsensical code if the frontend doesn't change the field value at all before feeding the `TargetOptions` to the target machine initializer.

Reviewed By: nickdesaulniers

Differential Revision: https://reviews.llvm.org/D99952




More information about the All-commits mailing list