[all-commits] [llvm/llvm-project] 9456e7: [lld-macho][nfc] Rename some tests

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9456e720ec8465a9da2acbda14cd7d67cddf16f7
      https://github.com/llvm/llvm-project/commit/9456e720ec8465a9da2acbda14cd7d67cddf16f7
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
    R lld/test/MachO/dylink-lazy.s
    R lld/test/MachO/stub-framework.s
    R lld/test/MachO/stub-link-by-arch.s
    R lld/test/MachO/stub-link.s
    A lld/test/MachO/tapi-framework.s
    A lld/test/MachO/tapi-link-by-arch.s
    A lld/test/MachO/tapi-link.s
    A lld/test/MachO/x86-64-stubs.s

  Log Message:
  -----------
  [lld-macho][nfc] Rename some tests

"stub" is a bit too overloaded... we were using it to refer to
TAPI files, but it's also the name for the PLT trampolines in Mach-O.
Going ahead, let's just use "TAPI" or ".tbd" to refer to TAPI stuff.

Reviewed By: #lld-macho, oontvoo

Differential Revision: https://reviews.llvm.org/D99807


  Commit: 94f75202accb26d71fd3149f410e80d602fc562d
      https://github.com/llvm/llvm-project/commit/94f75202accb26d71fd3149f410e80d602fc562d
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
    M lld/MachO/Options.td
    M lld/test/MachO/sectcreate.s
    M lld/test/MachO/why-load.s

  Log Message:
  -----------
  [lld-macho][nfc] Remove HelpHidden from aliases to implemented flags

This is a no-op. Just cleaning up Options.td...

Reviewed By: #lld-macho, oontvoo

Differential Revision: https://reviews.llvm.org/D99874


  Commit: ceec610754b045cdac4ae0d705d8d9651e323fc4
      https://github.com/llvm/llvm-project/commit/ceec610754b045cdac4ae0d705d8d9651e323fc4
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/MachO/SymbolTable.cpp
    M lld/MachO/Symbols.h
    M lld/test/MachO/stabs.s
    M lld/test/MachO/symtab.s

  Log Message:
  -----------
  [lld-macho] Fix & refactor symbol size calculations

I noticed two problems with the previous implementation:

* N_ALT_ENTRY symbols weren't being handled correctly -- they should
  determine the size of the previous symbol, even though they don't
  cause a new section to be created
* The last symbol in a section had its size calculated wrongly;
  the first subsection's size was used instead of the last one

I decided to take the opportunity to refactor things as well, mainly to
realize my observation
[here](https://reviews.llvm.org/D98837#inline-931511) that we could
avoid doing a binary search to match symbols with subsections. I think
the resulting code is a bit simpler too.

      N           Min           Max        Median           Avg        Stddev
  x  20          4.31          4.43          4.37        4.3775   0.034162922
  +  20          4.32          4.43          4.38        4.3755    0.02799906
  No difference proven at 95.0% confidence

Reviewed By: #lld-macho, alexshap

Differential Revision: https://reviews.llvm.org/D99972


Compare: https://github.com/llvm/llvm-project/compare/1d9d7f6a2c0f...ceec610754b0