[all-commits] [llvm/llvm-project] e0df2b: [lld-macho] Rename SubsectionMapping to SubsectionMap

Jez Ng via All-commits all-commits at lists.llvm.org
Tue Apr 6 11:26:46 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e0df2b540a5a7d6076bb77352e50fcd0e14522e0
      https://github.com/llvm/llvm-project/commit/e0df2b540a5a7d6076bb77352e50fcd0e14522e0
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputFiles.h

  Log Message:
  -----------
  [lld-macho] Rename SubsectionMapping to SubsectionMap

We bikeshedded about it here: https://reviews.llvm.org/D98837#inline-931557

I initially suggested SubsectionMapping, but I thought the discussion
landed on doing `std::vector<SubsectionEntry>`. @alexshap went and did
both, but on hindsight I regret adding 3 more characters to an already
long name, and I think SubsectionEntry is descriptive enough...

This diff also renames `subsectionMap` to `subsecMap` for consistency
with other variable names in the codebase.


  Commit: 174deb0539ee4af7d20bfead9f73055782e878e3
      https://github.com/llvm/llvm-project/commit/174deb0539ee4af7d20bfead9f73055782e878e3
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/MachO/Driver.h
    M lld/MachO/Symbols.cpp
    M lld/MachO/Symbols.h
    M lld/MachO/SyntheticSections.cpp

  Log Message:
  -----------
  [lld-macho] clang-format cleanup

  find . -type f -name "*.cpp" -o -name "*.h" | xargs clang-format -i


Compare: https://github.com/llvm/llvm-project/compare/a6d2a8d6f59a...174deb0539ee


More information about the All-commits mailing list