[all-commits] [llvm/llvm-project] 9c5ebf: [test, GVN] Fix use of var defined in CHECK-NOT

RoboTux via All-commits all-commits at lists.llvm.org
Tue Apr 6 09:00:34 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9c5ebf0358960adf28931569a0c801b56c8008d9
      https://github.com/llvm/llvm-project/commit/9c5ebf0358960adf28931569a0c801b56c8008d9
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2021-04-06 (Tue, 06 Apr 2021)

  Changed paths:
    M llvm/test/Transforms/GVN/PRE/load-pre-nonlocal.ll
    M llvm/test/Transforms/GVN/big-endian.ll
    M llvm/test/Transforms/NewGVN/big-endian.ll

  Log Message:
  -----------
  [test, GVN] Fix use of var defined in CHECK-NOT

Commit 22ce5eb051591b828b1ce4238624b6e95d334a5b, changed checks in
GVN/big-endian.ll into CHECK-NOT. The intent was to check that a
succession of lines does not occur but each CHECK-NOT is checked
independently. In other word, one CHECK-NOT uses a variable defined
in a pattern (the one defining the variable) that should not occur in
the input. The bug was then copied over in NewGVN/big-endian.ll.

This commit only checks for the absence of i16 load which rules out the
presence of the whole sequence and does not involve an undefined
variable.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D99581




More information about the All-commits mailing list