[all-commits] [llvm/llvm-project] f8013a: [libcxx] [test] Make the condvar wait_for tests a ...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f8013a35b6fb02ad35008c373f7b06a24b5dd8e4
      https://github.com/llvm/llvm-project/commit/f8013a35b6fb02ad35008c373f7b06a24b5dd8e4
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
    M libcxx/test/std/thread/thread.condition/thread.condition.condvar/wait_for.pass.cpp
    M libcxx/test/std/thread/thread.condition/thread.condition.condvarany/wait_for.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Make the condvar wait_for tests a bit more understandable. NFC.

This was requested in the review of D99175; rename the "runs"
variable to clarify what it means wrt the test, and move updating of
it to the main function to clarify its behaviour wrt the two runs
further.

Differential Revision: https://reviews.llvm.org/D99768


  Commit: 28ea218417d713bcb399e9428e4c3f8f7960feb2
      https://github.com/llvm/llvm-project/commit/28ea218417d713bcb399e9428e4c3f8f7960feb2
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-04-02 (Fri, 02 Apr 2021)

  Changed paths:
    M libcxx/test/std/concepts/concepts.callable/concept.invocable/invocable.compile.pass.cpp
    M libcxx/test/std/concepts/concepts.callable/concept.regularinvocable/regular_invocable.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Fix invocable tests on Windows

MSVC had a bug regarding preferring intergral conversions over
floating conversions. This is fixed in MSVC 19.28 and newer. Clang in
MSVC mode so far only mimics the old, buggy behaviour, but will
hopefully soon be fixed to comply with the new behaviour too
(see https://reviews.llvm.org/D99663).

Make the negative test to use a distinctly different type,
leaving checks for compiler specific bugs out of the libcxx test.

Differential Revision: https://reviews.llvm.org/D99641


Compare: https://github.com/llvm/llvm-project/compare/a89fb29398dc...28ea218417d7