[all-commits] [llvm/llvm-project] ffa15e: Extract isVolatile helper on Instruction [NFCI]

[Philip Reames via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ffa15e9463d07e9ba75e2c072afbc0c33f4f68a0
      https://github.com/llvm/llvm-project/commit/ffa15e9463d07e9ba75e2c072afbc0c33f4f68a0
  Author: Philip Reames <listmail at philipreames.com>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M llvm/include/llvm/IR/Instruction.h
    M llvm/lib/Analysis/MemoryDependenceAnalysis.cpp
    M llvm/lib/IR/Instruction.cpp
    M llvm/lib/Transforms/IPO/AttributorAttributes.cpp

  Log Message:
  -----------
  Extract isVolatile helper on Instruction [NFCI]

We have this logic duplicated in several cases, none of which were exhaustive.  Consolidate it in one place.

I don't believe this actually impacts behavior of the callers.  I think they all filter their inputs such that their partial implementations were correct.  If not, this might be fixing a cornercase bug.