[all-commits] [llvm/llvm-project] 48e3da: [lldb] Rewrite TestAutoInstallMainExecutable logic

Pavel Labath via All-commits all-commits at lists.llvm.org
Thu Apr 1 05:20:47 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 48e3da13519dea3bd91ab7de656c7d46105c2c01
      https://github.com/llvm/llvm-project/commit/48e3da13519dea3bd91ab7de656c7d46105c2c01
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M lldb/test/API/commands/target/auto-install-main-executable/Makefile
    M lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
    M lldb/test/API/commands/target/auto-install-main-executable/main.cpp

  Log Message:
  -----------
  [lldb] Rewrite TestAutoInstallMainExecutable logic

The test uses debug info from one binary to debug a different one. This
does not work on macos, and its pure luck that it works elsewhere (the
variable that it inspects happens to have the same address in both).

The purpose of this test is to verify that lldb has not overwritten the
target executable. That can be more easily achieved by checking the exit
code of the binary, so change the test to do that.

Also remove the llgs_test decorator, as it's preventing the test from
running on macos. All the test needs is the platform functionality of
lldb-server, which is available everywhere.




More information about the All-commits mailing list