[all-commits] [llvm/llvm-project] dfc8da: [lldb] Remove LLDB_CAPTURE_REPRODUCER override

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Mar 31 21:11:12 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dfc8da19c5d7ed48f62a4cc588b641f2deee8789
      https://github.com/llvm/llvm-project/commit/dfc8da19c5d7ed48f62a4cc588b641f2deee8789
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
    M lldb/source/Utility/Reproducer.cpp

  Log Message:
  -----------
  [lldb] Remove LLDB_CAPTURE_REPRODUCER override

Remove the LLDB_CAPTURE_REPRODUCER as it is inherently dangerous. The
reproducers require careful initialization which cannot be guaranteed by
overwriting the reproducer mode at this level.

If we want to provide this functionality, we should do it in the driver
instead. It was originally added to enable capture in CI, but we now
have a dedicated CI job that captures and replays the test suite.




More information about the All-commits mailing list