[all-commits] [llvm/llvm-project] 09aed3: [lld-macho][nfc] Test that -ObjC will import bitco...

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 09aed384ba19ff8b74763bdc42467232c9c012b3
      https://github.com/llvm/llvm-project/commit/09aed384ba19ff8b74763bdc42467232c9c012b3
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
    M lld/test/MachO/lto-archive.ll

  Log Message:
  -----------
  [lld-macho][nfc] Test that -ObjC will import bitcode with category sections

The functionality was originally added in {D95265}, but the test in that
diff only checked if `-ObjC` would cause bitcode containing ObjC class
symbols to be loaded. It neglected to test for bitcode containing
categories but no class symbols.

This diff also changes the lto-archive.ll test to use `-why_load`
instead of inspecting the output binary's symbol table. This is
motivated by the stacked diff {D99105}, which will hide irrelevant
bitcode symbols.

Reviewed By: #lld-macho, oontvoo

Differential Revision: https://reviews.llvm.org/D99215


  Commit: 9b6dde8af8f0880690792e3faa7987a8529232f6
      https://github.com/llvm/llvm-project/commit/9b6dde8af8f0880690792e3faa7987a8529232f6
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
    M lld/ELF/Writer.cpp
    M lld/MachO/Writer.cpp
    A lld/include/lld/Common/Arrays.h

  Log Message:
  -----------
  [lld-macho] Parallelize UUID hash computation

This reuses the approach (and some code) from LLD-ELF.

It's a decent win when linking chromium_framework on a Mac Pro (3.2 GHz 16-Core Intel Xeon W):

      N           Min           Max        Median           Avg        Stddev
  x  20          4.58          4.83          4.66        4.6685   0.066591844
  +  20          4.42          4.61           4.5         4.505    0.04751731
  Difference at 95.0% confidence
          -0.1635 +/- 0.0370242
          -3.5022% +/- 0.793064%
          (Student's t, pooled s = 0.0578462)

The output binary is 381MB.

Reviewed By: #lld-macho, oontvoo

Differential Revision: https://reviews.llvm.org/D99279


Compare: https://github.com/llvm/llvm-project/compare/4ced958dc205...9b6dde8af8f0