[all-commits] [llvm/llvm-project] 4a0a85: [libcxx] [test] Fix tests of <cuchar> that unexpec...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4a0a85becc9e19d288b5adcf713cb9e135c7f022
      https://github.com/llvm/llvm-project/commit/4a0a85becc9e19d288b5adcf713cb9e135c7f022
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
    M libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
    M libcxx/test/std/strings/c.strings/cuchar.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Fix tests of <cuchar> that unexpectedly succeed on windows

The tests expect that the <cuchar> include should fail. When libc++
is built on top of the MSVC runtime, the header does exist provided
by MSVC. Therefore, just mark the test as unsupported on windows,
to avoid tests that unexpectedly succeed.

Differential Revision: https://reviews.llvm.org/D99096


  Commit: 7acfd85756736b2e240cc3a4ffd56f26d73ace9e
      https://github.com/llvm/llvm-project/commit/7acfd85756736b2e240cc3a4ffd56f26d73ace9e
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-31 (Wed, 31 Mar 2021)

  Changed paths:
    M libcxx/utils/libcxx/test/config.py

  Log Message:
  -----------
  [libcxx] [test] Don't add dirs from the LIB env var to PATH

The directories in LIB normally only contain import libraries or
static libraries, no runtime DLLs that would need to be found
while running tests.

This code stems from 1cd196e7b46e49d170a4b4013879a577dee59cb2,
which (among other things) tried to do this:

> * [Test] Fix handling of library runtime search paths by correctly adding them
>   to the PATH variable when running the tests.

It's unclear to me exactly what this fixed (or tried to) at the time,
as the LIB var doesn't normally point to runtime libs.

Differential Revision: https://reviews.llvm.org/D99241


Compare: https://github.com/llvm/llvm-project/compare/32ca5a037ab9...7acfd8575673