[all-commits] [llvm/llvm-project] 4e0045: libc: Default LIBC_INSTALL_PREFIX to ${CMAKE_INSTA...

Nathan Chancellor via All-commits all-commits at lists.llvm.org
Tue Mar 30 21:48:51 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e0045cc9b00ed18a7b8981d468a9d01eb4f6780
      https://github.com/llvm/llvm-project/commit/4e0045cc9b00ed18a7b8981d468a9d01eb4f6780
  Author: Nathan Chancellor <nathan at kernel.org>
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
    M libc/CMakeLists.txt

  Log Message:
  -----------
  libc: Default LIBC_INSTALL_PREFIX to ${CMAKE_INSTALL_PREFIX}

b22f448c21e718a3b6 added a rule to install libllvmlibc.a to
${LIBC_INSTALL_PREFIX}/${LIBC_INSTALL_LIBRARY_DIR}, which will be /lib
by default, which is disruptive to builds that stay within a user's
/home holder:

  $ ninja install
  ...
  -- Installing: /lib/libllvmlibc.a
  CMake Error at projects/libc/lib/cmake_install.cmake:54 (file):
    file INSTALL cannot copy file
   "/home/nathan/cbl/github/tc-build/build/llvm/stage1/projects/libc/lib/libllvmlibc.a"
    to "/lib/libllvmlibc.a": Permission denied.
  Call Stack (most recent call first):
    projects/libc/cmake_install.cmake:51 (include)
    projects/cmake_install.cmake:47 (include)
    cmake_install.cmake:76 (include)
  ...

Change LIBC_INSTALL_PREFIX's default value to ${CMAKE_INSTALL_PREFIX} so
that 'ninja install' does not attempt to install anything outside of the
user's requested installation location.

Differential Revision: https://reviews.llvm.org/D99636

Reviewed By: sivachandra

Signed-off-by: Nathan Chancellor <nathan at kernel.org>




More information about the All-commits mailing list