[all-commits] [llvm/llvm-project] a6950c: [test, ARM] Fix use of var defined in CHECK-NOT

RoboTux via All-commits all-commits at lists.llvm.org
Tue Mar 30 08:28:26 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6950c33e8604552eb2d933138a576758633343e
      https://github.com/llvm/llvm-project/commit/a6950c33e8604552eb2d933138a576758633343e
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2021-03-30 (Tue, 30 Mar 2021)

  Changed paths:
    M llvm/test/Transforms/CodeGenPrepare/ARM/sink-add-mul-shufflevector-inseltpoison.ll
    M llvm/test/Transforms/CodeGenPrepare/ARM/sink-add-mul-shufflevector.ll

  Log Message:
  -----------
  [test, ARM] Fix use of var defined in CHECK-NOT

tries to check for the
    absence of a sequence of instructions with several CHECK-NOT with
one of
    those directives using a variable defined in another.

LLVM test CodeGenPrepare/ARM/sink-add-mul-shufflevector.ll tries to
check for the absence of a sequence of instructions with several
CHECK-NOT with one of those directives using a variable defined in
another. However, CHECK-NOT are checked independently so that is using
a variable defined in a pattern that should not occur in the input. The
bug was then copied over in
Transforms/CodeGenPrepare/ARM/sink-add-mul-shufflevector-inseltpoison.ll

This commit removes the definition and uses of variable to check each
line independently, making the check stronger than the current one.

Reviewed By: dmgreen

Differential Revision: https://reviews.llvm.org/D99597




More information about the All-commits mailing list