[all-commits] [llvm/llvm-project] 3c95bd: [lldb] Don't search for system specific strings in...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Mon Mar 29 01:47:09 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3c95bdf9fa35f0fe2143ea859b624c8f09513adb
      https://github.com/llvm/llvm-project/commit/3c95bdf9fa35f0fe2143ea859b624c8f09513adb
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
    M lldb/test/Shell/Error/assert.test

  Log Message:
  -----------
  [lldb] Don't search for system specific strings in assert.test

Commit 6bc1e69de270db8d7191200f54158e4192f997ba changed the search string
to also check for the generated strings that surround the plain assert:

    Assertion `false && "lldb-test assert"' failed
                                         ^^^^^^^^^

This causes the test to fail on setups where the generated assert message
looks different. E.g., on macOS the generated message looks like this:

    Assertion failed: (false && "lldb_assert failed"), function lldb_assert

This reverts the old behaviour of just checking for the actual string we
have inside LLDB.




More information about the All-commits mailing list