[all-commits] [llvm/llvm-project] 0135bc: [clang] Always execute multi-stage install steps

[Shoaib Meenai via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0135bc996d82ff68677820c421b4d666590e4f31
      https://github.com/llvm/llvm-project/commit/0135bc996d82ff68677820c421b4d666590e4f31
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M clang/CMakeLists.txt

  Log Message:
  -----------
  [clang] Always execute multi-stage install steps

We want installs to be executed even if binaries haven't changed, e.g.
so that we can install to multiple places. This is consistent with how
non-multi-stage install targets (e.g. the regular install-distribution
target) behave.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D99321


  Commit: 33930a0787f6007ba7ebf36384115bebb412e08a
      https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M clang/CMakeLists.txt

  Log Message:
  -----------
  [clang] Pass option directly to command. NFC

This code was written back when LLVM's minimum required CMake version
was 2.8.8, and I assume ExternalProject_Add_Step didn't take this option
at that point. It does now though, so we should just use the option.
Setting the _EP_* property is entirely equivalent (and is in fact how
these commands behave internally), but that also feels like an internal
implementation detail we shouldn't be relying on.

Reviewed By: beanz

Differential Revision: https://reviews.llvm.org/D99322


Compare: https://github.com/llvm/llvm-project/compare/61a55c8812e7...33930a0787f6