[all-commits] [llvm/llvm-project] f7ef26: [SLP] Fix crash in reduction for integer min/max

Yevgeny Rouban via All-commits all-commits at lists.llvm.org
Thu Mar 25 08:03:46 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f7ef26ef0b29a7c864209b78abf4445407a154b1
      https://github.com/llvm/llvm-project/commit/f7ef26ef0b29a7c864209b78abf4445407a154b1
  Author: Yevgeny Rouban <yrouban at azul.com>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
    M llvm/test/Transforms/SLPVectorizer/slp-umax-rdx-matcher-crash.ll

  Log Message:
  -----------
  [SLP] Fix crash in reduction for integer min/max

The SCEV commit b46c085d2b6d1 [NFCI] SCEVExpander:
    emit intrinsics for integral {u,s}{min,max} SCEV expressions
seems to reveal a new crash in SLPVectorizer.
SLP crashes expecting a SelectInst as an externally used value
but umin() call is found.

The patch relaxes the assumption to make the IR flag propagation safe.

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D99328




More information about the All-commits mailing list