[all-commits] [llvm/llvm-project] a88556: [LLD] Fix probing a MSYS based 'tar' in a Windows ...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a88556733a4dced22416bd3f45255128b9eb4f49
      https://github.com/llvm/llvm-project/commit/a88556733a4dced22416bd3f45255128b9eb4f49
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M lld/test/lit.cfg.py

  Log Message:
  -----------
  [LLD] Fix probing a MSYS based 'tar' in a Windows Container

Don't run the 'tar' tool in a cleared environment with only the
LANG variable set, just set LANG on top of the existing environment.

If the 'tar' tool is an MSYS based tool, running it in a Windows
Container hangs if all environment variables are cleared - in
particular, the USERPROFILE variable needs to be kept intact.

This is the same issue fixed as was fixed in other places in
9de63b2e051cb3e79645cc20b83b4d33d132cba0, but contrary to running
the actual tests, running with an as-cleared-as-possible environment
here is less important.

Differential Revision: https://reviews.llvm.org/D99304


  Commit: b8b23aa80eefe84187d6ba364d06496c90c53bdb
      https://github.com/llvm/llvm-project/commit/b8b23aa80eefe84187d6ba364d06496c90c53bdb
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M libcxx/utils/ssh.py

  Log Message:
  -----------
  [libcxx] [test] Quote env variables that are set with a shell "export" in ssh.py

This safeguards against cases if some of the env vars contain chars
that are problematic for shells, e.g. if called with --env "X=Y;Z".

(In cases of cross testing for windows, the PATH variable can end up
specified with semicolon separators - even if specifying a PATH when
cross testing in such differing environments might not make sense or
do anything - but this makes ssh.py not break on such a variable.)

Differential Revision: https://reviews.llvm.org/D99242


Compare: https://github.com/llvm/llvm-project/compare/32f6a15dfd52...b8b23aa80eef