[all-commits] [llvm/llvm-project] 6869e6: [InlineCost] Make cost-benefit decision explicit

WenleiHe via All-commits all-commits at lists.llvm.org
Wed Mar 24 16:11:29 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6869e6c1e7f88d06a5db44e46933843247887040
      https://github.com/llvm/llvm-project/commit/6869e6c1e7f88d06a5db44e46933843247887040
  Author: Wenlei He <aktoon at gmail.com>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M llvm/lib/Analysis/InlineCost.cpp
    M llvm/test/Other/optimization-remarks-auto.ll

  Log Message:
  -----------
  [InlineCost] Make cost-benefit decision explicit

With cost-benefit analysis for inlining, we bypass the cost-threshold by returning inline result from call analyzer early.

However the cost and threshold are still available from call analyzer, and when cost is actually higher than threshold, we incorrect set the reason.

The change makes the decision from cost-benefit analysis explicit. It's mostly NFC, except that it allows the priority-based sample loader inliner used by CSSPGO to use cost-benefit heuristic.

Differential Revision: https://reviews.llvm.org/D99302




More information about the All-commits mailing list