[all-commits] [llvm/llvm-project] c8faa8: Make the stop-on-sharedlibrary-events setting work.

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c8faa8c2669c1867ef6ac33466f219a39d5faaa7
      https://github.com/llvm/llvm-project/commit/c8faa8c2669c1867ef6ac33466f219a39d5faaa7
  Author: Jim Ingham <jingham at apple.com>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M lldb/include/lldb/Breakpoint/BreakpointLocation.h
    M lldb/source/Breakpoint/BreakpointLocation.cpp
    M lldb/source/Breakpoint/BreakpointOptions.cpp
    M lldb/source/Target/StopInfo.cpp
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/Makefile
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/TestStopOnSharedlibraryEvents.py
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/a.cpp
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/b.cpp
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/main.cpp

  Log Message:
  -----------
  Make the stop-on-sharedlibrary-events setting work.

The StopInfoBreakpoint::PerformAction was overriding the synchronous
breakpoint's ShouldStop report.  Fix that and add a test.

This fixes two bugs in the original submission:
1) Actually generate both dylibs by including the second one in the Makefile
2) Don't ask synchronous callbacks for their opinion on whether to stop
   in the async context, that info is taken care of by recording the m_should_stop
   on entry to PerformAction.

Differential Revision: https://reviews.llvm.org/D98914