[all-commits] [llvm/llvm-project] a6a1c3: Fix false negative in -Wthread-safety-attributes

Aaron Puchert via All-commits all-commits at lists.llvm.org
Wed Mar 24 09:46:32 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6a1c3051dbd2cc5ccc70272890cf38d11dca9c7
      https://github.com/llvm/llvm-project/commit/a6a1c3051dbd2cc5ccc70272890cf38d11dca9c7
  Author: Aaron Puchert <aaron.puchert at sap.com>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M clang/lib/Sema/SemaDeclAttr.cpp
    M clang/test/SemaCXX/warn-thread-safety-parsing.cpp

  Log Message:
  -----------
  Fix false negative in -Wthread-safety-attributes

The original implementation didn't fire on non-template classes when a
base class was an instantiation of a template with a dependent base.
In that case the base of the base is dependent as seen from the base,
but not from the class we're interested in, which isn't a template.

Also it simplifies the code a lot.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D98724




More information about the All-commits mailing list