[all-commits] [llvm/llvm-project] b6c4b2: [libcxx] [test] Add return values after assert(fal...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Wed Mar 24 02:44:24 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b6c4b280a01f1a16b0b4258a1034bebc13f1f7e3
      https://github.com/llvm/llvm-project/commit/b6c4b280a01f1a16b0b4258a1034bebc13f1f7e3
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M libcxx/test/std/experimental/memory/memory.resource.global/new_delete_resource.pass.cpp
    M libcxx/test/std/experimental/memory/memory.resource.global/null_memory_resource.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Add return values after assert(false) in some experimental tests

When building in MSVC mode (in release mode), the assert(false) don't
make the end of the function unreachable, so add return statements to
silence compiler warnings (treated as errors).

Also change 'virtual' into 'override', which was requested in review,
as these files require C++11.

Differential Revision: https://reviews.llvm.org/D99214




More information about the All-commits mailing list