[all-commits] [llvm/llvm-project] e97d92: [flang] Disallow erroneous procedure declarations

[Pete Steinfeld via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e97d92f0bb998e7d93b4e91d550ba0492d9c414b
      https://github.com/llvm/llvm-project/commit/e97d92f0bb998e7d93b4e91d550ba0492d9c414b
  Author: Peter Steinfeld <psteinfeld at nvidia.com>
  Date:   2021-03-22 (Mon, 22 Mar 2021)

  Changed paths:
    M flang/lib/Semantics/resolve-names.cpp
    M flang/test/Semantics/resolve18.f90

  Log Message:
  -----------
  [flang] Disallow erroneous procedure declarations

When writing tests for a previous problem, I ran across situations where we
were not producing error messages for declarations of specific procedures of
generic interfaces where every other compiler I tested (except nvfotran) did.
I added a check to CheckExtantExternal() and renamed it since it now checks for
erroneous extant symbols generally.

I also removed a call to this function from processing for ENTRY statements,
since it seemed unnecessary and its presence caused bogus error messages.

I also added some tests for erroneous declarations where we were not producing
error messages.

Differential Revision: https://reviews.llvm.org/D99111