[all-commits] [llvm/llvm-project] 2f13e6: [LegalizeDAG] Add asserts to verify the types of c...

Craig Topper via All-commits all-commits at lists.llvm.org
Mon Mar 22 10:31:15 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f13e63f9eefa36013f3165523d5e193bc1598ad
      https://github.com/llvm/llvm-project/commit/2f13e63f9eefa36013f3165523d5e193bc1598ad
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-03-22 (Mon, 22 Mar 2021)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

  Log Message:
  -----------
  [LegalizeDAG] Add asserts to verify the types of custom legalized operation matches the original node.

We've messed this up a few times recently on RISCV. Experiments
with these asserts found a couple issues on other targets as well.
They've all been cleaned up now so we can put in these asserts to
catch future issues

I had to waive Glue because ADDC/ADDE/etc legalization replaces
Glue with i32 on at least AArch64. X86 used to do the same before
we switched to ADDCARRY. So I guess that's just how that works.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D98979




More information about the All-commits mailing list